[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

IIUC `default(firstprivate)` is being added in openmp-5.1,
it is not in openmp-4.5, so it should not be accepted
in pre-openmp-5.1-mode (i.e. it should be diagnosed)



================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:56
+  DSA_firstprivate =
+      1 << 1 | 1, /// Default data sharing attribute 'firstprivate'.
 };
----------------
why `0b11` ? shouldn't this be `0b100` (`1 << 2`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75591/new/

https://reviews.llvm.org/D75591