[PATCH] D74205: [llvm-dwarfdump] Add the --show-sections-sizes option

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp:650
+    for (auto Object : Objects)
+      handleFile(Object, collectSecsSizesForObjectFile, OutputFile.os());
+  } else {
----------------
jhenderson wrote:
> It looks like you handle each file individually, which is fine, but it probably makes sense to include the file name somewhere in your output too, to clearly distinguish them. Also, as you can have multiple inputs, you should have a test for that (possibly it can be part of the existing test).
>It looks like you handle each file individually, which is fine, but it probably makes sense to include the file name somewhere in your output too, to clearly distinguish them. 

This was already there, the output starts as following:

  test_name: file format ELF64-x86-64
  --------------------------------------------


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74205/new/

https://reviews.llvm.org/D74205