[PATCH] D75528: [yaml2obj][obj2yaml][test] - Add base tests for relocation addends.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 00:39:08 PST 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/relocation-addend.yaml:22
+
+## Check how obj2yaml dumps an addend with the value = MAX_INT64.
+# RUN: yaml2obj --docnum=1 %s -o %t3 -D ADDEND=9223372036854775807
----------------
MaskRay wrote:
> The stdint.h constant is named `INT64_MIN`
> 
> Testing the hexadecimal literal will be useful, too.
It is a test for `obj2yaml`, it only can print decimals.

Hexadecimal values as inputs are tested in yaml2obj test suite.

> The stdint.h constant is named INT64_MIN

I'll rename, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75528/new/

https://reviews.llvm.org/D75528





More information about the llvm-commits mailing list