[PATCH] D75357: [X86] Add a private member function determinePaddingPrefix for X86AsmBackend

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 22:21:12 PST 2020


skan marked 3 inline comments as done.
skan added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:345
+  const MCInstrDesc &Desc = MCII->get(Opcode);
+  uint64_t TSFlags = Desc.TSFlags;
+
----------------
MaskRay wrote:
> Consider omitting `TSFlags`. It is used just twice.
Prefer to keep unchanged.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75357/new/

https://reviews.llvm.org/D75357





More information about the llvm-commits mailing list