[PATCH] D75545: [dsymutil] Fix template stripping in getDIENames(...) to account for overloaded operators

Shafik Yaghmour via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 17:16:47 PST 2020


shafik marked an inline comment as done.
shafik added inline comments.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:170
+          StringPool.getEntry(name.substr(0, start_of_template - 1));
+    }
   }
----------------
JDevlieghere wrote:
> We should extract this logic in a static function, something like `StringRef stripTemplateFromName(StringRef Str);`. 
Just realized I missed this comment, I will extract this out in the next update.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75545/new/

https://reviews.llvm.org/D75545





More information about the llvm-commits mailing list