[PATCH] D75084: [ORC] Decompose LazyCallThroughManager::callThroughToSymbol()

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 17:16:46 PST 2020


lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

Style suggestion aside, LGTM. Thanks very much Stefan!



================
Comment at: llvm/include/llvm/ExecutionEngine/Orc/LazyReexports.h:109
+
+          return *ResolvedAddr;
         });
----------------
Could this lambda be factored out into a callThroughToSymbol method on LocalLazyCallThroughManager for consistency with NotifyingCallThroughManager?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75084/new/

https://reviews.llvm.org/D75084





More information about the llvm-commits mailing list