[PATCH] D75338: [Coroutines] Use dbg.declare for frame variables

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 16:49:14 PST 2020



> On Mar 2, 2020, at 7:03 PM, Brian Gesiak via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> modocache added a comment.
> 
>> They are not broken [1], but you may need to add libcxx and friends to your list of projects in your LLVM cmake invocation.
> 
> Thanks for the link to the buildbot! In my comment above, I mention:
> 
>> Also, for what it's worth, I tried a configuration that used `cmake -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;libcxx;libcxxabi;lld;lldb"` and `ninja check-all`, and these same 39 tests also failed.
> 
> When you say "add libcxx and friends to your list of projects in your LLVM cmake invocation", do you mean `-DLLVM_ENABLE_PROJECTS=`, or something else? The primary difference I see between my own build invocation and the buildbot is that it passes `-DLLDB_TEST_USER_ARGS=...`. I'll try mimicking those to see if that works. But, if it's alright, I think I'd like to respond to @jmorse's review comments and commit this patch, and add an lldb regression test in a separate follow-up patch.

For reference, here is what I am using to build locally for testing: 

$ xcrun cmake -G Ninja -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DLLVM_ENABLE_MODULES=On -DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra;libcxx;libcxxabi;lldb;compiler-rt;lld;debuginfo-tests' ../llvm

maybe that helps!
-- adrian


More information about the llvm-commits mailing list