[PATCH] D75516: [GlobalISel] Add missing floating point and s128 libcall support

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 15:00:32 PST 2020


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:465-467
+    return Size == 128 ? RTLIB::SREM_I128
+                       : Size == 64 ? RTLIB::SREM_I64 : RTLIB::SREM_I32;
   case TargetOpcode::G_UREM:
----------------
Should there be a table for this? The nested ternary operators are becoming unwieldy


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75516/new/

https://reviews.llvm.org/D75516





More information about the llvm-commits mailing list