[PATCH] D74691: [Attributor] Detect possibly unbounded cycles in functions

omar ahmed via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 14:24:43 PST 2020


omarahmed added a comment.

> Please add a non-loop cycle test case, aka. irreducible control flow test case.

okay I will add it in the next diff :)
@baziotis 
have found a test case that will fail in this bfs approach :

  define i32* @test2(i32* %n0, i32* %r0, i32* %w0) {
  entry:
    %tobool = icmp ne i32* %n0, null
    br i1 %tobool, label %l2, label %l1
  
  l1:
    br label %l2
  
  l2:
    br label %return
  
  return:
    ret i32* %w0
  }

he also proposed a new approach I think will be very good in most cycles , so I am a bit puzzeled should I modify this one or work again on the new approach :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691





More information about the llvm-commits mailing list