[PATCH] D75305: [AIX] Handle LinkOnceODRLinkage and llvm.global_ctors/dtors' AppendingLinkage

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 14:24:43 PST 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-AppendingLinkage.ll:22
+; CHECK-NOT: llvm.global_dtors
+; CHECK-NOT: Should never emit it.
----------------
stevewan wrote:
> As a reminder, if you are to change `llvm_unreachable("Should never emit it.");` to something else, this check will need to be updated as well.
The message will cause a non-zero return code. We do not need this check; if we did, we should probably be piping the stderr to `FileCheck`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75305/new/

https://reviews.llvm.org/D75305





More information about the llvm-commits mailing list