[PATCH] D75375: [MCDwarf] Generate DWARF v5 .debug_rnglists for assembly files

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/lib/MC/MCDwarf.cpp:48-59
+void mcdwarf::emitListsTableHeaderStart(MCStreamer *S, MCSymbol *TableStart,
+                                        MCSymbol *TableEnd) {
+  S->AddComment("Length");
+  S->emitAbsoluteSymbolDiff(TableEnd, TableStart, 4);
+  S->emitLabel(TableStart);
+  S->AddComment("Version");
+  S->emitInt16(S->getContext().getDwarfVersion());
----------------
MaskRay wrote:
> dblaikie wrote:
> > Please pass "S" by reference here, since it's unconditionally dereferenced (so the null state isn't needed) - this will simplify some of the callers too (x.get() -> *x)
> > 
> > TableStart and TableEnd can remain pointers since their underlying APIs use them/they're more "tokens" to pass around.
> Agreed with the analysis.
> 
> It also makes sense for `MCStreamer::emitAbsoluteSymbolDiff` to take references as parameters. However, `MCSymbol *` typed parameters are much more common than `MCSymbol &`.
https://reviews.llvm.org/D75568


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75375/new/

https://reviews.llvm.org/D75375