[PATCH] D75188: [NFC][DebugInfo] Refactor address advancing operations to share code

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 09:06:02 PST 2020


probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:917
         {
-          uint8_t AdjustOpcode = 255 - Prologue.OpcodeBase;
-          uint64_t AddrOffset =
-              (AdjustOpcode / Prologue.LineRange) * Prologue.MinInstLength;
-          State.Row.Address.Address += AddrOffset;
+          uint64_t AddrOffset = State.advanceAddrForOpcode(255).AddrDelta;
           if (OS)
----------------
It seems like there ought to be a symbol for opcode 255, but you inherited the code so I won't insist.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75188/new/

https://reviews.llvm.org/D75188





More information about the llvm-commits mailing list