[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked an inline comment as done.
SouraVX added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h:88
+    Expected<bool> setFlags(uint8_t Flags) {
+      if (Flags == MACRO_OFFSET_SIZE) {
+        Error Err =
----------------
ikudrin wrote:
> So, the code pretends to support DWARF64 if the `debug_line_offset` field is present, right?
`MACRO_OFFSET_SIZE` value [1] denotes 64 bit offset[DWARF64] hence we quit parsing early.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086