[PATCH] D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool

Tue Mar 3 08:38:21 PST 2020

TWeaver added inline comments.

================
Comment at: debuginfo-tests/dexter/dex/debugger/Debuggers.py:166
+    else:
+        step_collection.commands = OrderedDict()

----------------
I understand this is at the prototype stage, but... 😉 

This extra else step here I believe is to setup an empty dict that can be filled with commands generated by the test run for the annotated test file generation (correct me if I'm wrong).

I'm not completely against having an else statement here but I feel there should at least be a comment describing why we'd want differing behaviour.

Also, whilst I'm not a huge fan of the 'big-ball-of-context' approach taken in the past, we could reduce the parameter list to get_debugger_steps by interrogating the context object.

================
Comment at: debuginfo-tests/dexter/dex/tools/gen/Tool.py:103
+            nargs='?',
+            help='directory in which the generation tool will run')
+        parser.add_argument(
----------------
does this mean the generation tool runs inside the same directory the test is within?

if so, where does it store the newly generated/annotated test file?

thanks
Tom W

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75343/new/

https://reviews.llvm.org/D75343