[PATCH] D75123: [obj2yaml, yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 23:36:27 PST 2020


grimar added a comment.

In D75123#1901346 <https://reviews.llvm.org/D75123#1901346>, @MaskRay wrote:

> > This could possibly work, but I suspect people might be confused as to when to use one instead of the other. We probably need to update the `yaml2obj`/`obj2yaml` documentation. I might also suggest `ContentArray` as a name instead perhaps?
>
> I don't have a strong opinion. `ContentArray` looks fine. obj2yaml does not know the nature of the content (strings or blob), should it continue dumping to `Content` by default? (I'll vote for yes; no strong opinion) If yes, `ContentArray` will be a key only known by yaml2obj.


Yeah, I'd leave it only known by yaml2obj and continue dumping to `Content`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75123/new/

https://reviews.llvm.org/D75123





More information about the llvm-commits mailing list