[PATCH] D75438: [BranchAlign] Reduce the number of emitted fragments due to branch align

[Kan Shengchen via Phabricator via llvm-commits]

skan marked an inline comment as done.
skan added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:454
+
+  // We need to ensure that further data aren't added to the current data
+  // fragment.
----------------
reames wrote:
> I believe you can simply insert a new empty data fragment instead of adding the special state to all data fragments.  
> 
> Also, you only need to do so if the last fragment was a data fragment.  
If the next intruction is emitted into a relaxable fragment, the empty data fragment will be unused, is it acceptable to you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75438/new/

https://reviews.llvm.org/D75438