[PATCH] D75257: [mlir] NFC - Split out RunnerUtils that don't require a C++ runtime

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

This change broke the MLIR build on Windows.

As far as I can tell, the intention here is to produce two separate shared libraries: mlir_c_runner_utils and mlir_runner_utils with the second one (mlir_runner_utils) including the first one (mlir_c_runner_utils). Since:

`add_llvm_library(mlir_c_runner_utils SHARED CRunnerUtils.cpp)`

produces *only* a dll on windows, the linking of mlir_runner_utils fails because target_link_libraries is looking for a .lib file as opposed to a .dll file. I think this may be a case where either we need to use LINK_LIBS or explicitly build a static lib as well, but I haven't tried either yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75257/new/

https://reviews.llvm.org/D75257