[PATCH] D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 14:56:43 PST 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment.



================
Comment at: llvm/lib/CodeGen/MIRParser/MIParser.cpp:638
+  else
+    llvm_unreachable("Invalid Section Type!");
+  lex();
----------------
`error()`?  This code is pretty clearly reachable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73674/new/

https://reviews.llvm.org/D73674





More information about the llvm-commits mailing list