[PATCH] D75297: [TypeSize] Allow returning scalable size in implicit conversion to uint64_t

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 12:03:46 PST 2020


efriedma added a comment.

> Removing the assert would allow us to use the SVE ACLE intrinsics which don't rely on common optimisations.

Even without any optimizations that are specifically SVE-aware, we're going to generate a lot of instructions with SVE types that aren't SVE intrinsics.  In particular, I assume plain C assignment operations are going to lower to "load" and "store" instructions.  So really, this is trading assertions for subtle miscompiles in a lot of cases.

If you're trying to hit a certain deadline, maybe being unable to build any SVE code at all is worse than a bunch of subtle miscompiles?  That seems like a terrible tradeoff either way, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75297/new/

https://reviews.llvm.org/D75297





More information about the llvm-commits mailing list