[llvm] 21e8324 - Revert "Fix Base64Test - for StringRef size"

Mitch Phillips via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 09:33:56 PST 2020


Author: Mitch Phillips
Date: 2020-03-02T09:33:21-08:00
New Revision: 21e83244cf7ec5bc3eab81677c9cb15c4fb2d581

URL: https://github.com/llvm/llvm-project/commit/21e83244cf7ec5bc3eab81677c9cb15c4fb2d581
DIFF: https://github.com/llvm/llvm-project/commit/21e83244cf7ec5bc3eab81677c9cb15c4fb2d581.diff

LOG: Revert "Fix Base64Test - for StringRef size"

This reverts commit b52355f8a196b5040dc2e42870bf8c459306cfaa.

The change this patch depends on
(5a1958f2673f8c771e406a7e309e160b432c9a79) broke the UBSan buildbots.
See https://reviews.llvm.org/D75057 for more information.

Added: 
    

Modified: 
    llvm/unittests/Support/Base64Test.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/Support/Base64Test.cpp b/llvm/unittests/Support/Base64Test.cpp
index 9622c866b38a..0424678fe9c1 100644
--- a/llvm/unittests/Support/Base64Test.cpp
+++ b/llvm/unittests/Support/Base64Test.cpp
@@ -39,7 +39,8 @@ TEST(Base64Test, Base64) {
   // With non-printable values.
   char NonPrintableVector[] = {0x00, 0x00, 0x00,       0x46,
                                0x00, 0x08, (char)0xff, (char)0xee};
-  TestBase64({NonPrintableVector, sizeof(NonPrintableVector)}, "AAAARgAI/+4=");
+  TestBase64(StringRef(NonPrintableVector, sizeof(NonPrintableVector)),
+             "AAAARgAI/+4=");
 
   // Large test case
   char LargeVector[] = {0x54, 0x68, 0x65, 0x20, 0x71, 0x75, 0x69, 0x63, 0x6b,
@@ -47,6 +48,6 @@ TEST(Base64Test, Base64) {
                         0x78, 0x20, 0x6a, 0x75, 0x6d, 0x70, 0x73, 0x20, 0x6f,
                         0x76, 0x65, 0x72, 0x20, 0x31, 0x33, 0x20, 0x6c, 0x61,
                         0x7a, 0x79, 0x20, 0x64, 0x6f, 0x67, 0x73, 0x2e};
-  TestBase64({LargeVector, sizeof(LargeVector)},
+  TestBase64(LargeVector,
              "VGhlIHF1aWNrIGJyb3duIGZveCBqdW1wcyBvdmVyIDEzIGxhenkgZG9ncy4=");
 }


        


More information about the llvm-commits mailing list