[PATCH] D75201: [ThinLTO/LowerTypeTests] Handle unpromoted local type ids

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 09:31:10 PST 2020


tejohnson added a comment.

In D75201#1901184 <https://reviews.llvm.org/D75201#1901184>, @aganea wrote:

> Shouldn't we add `-D[CMAKE_C_FLAGS|CMAKE_CXX_FLAGS]="-fwhole-program-vtables"` , or better `-O3 -fwhole-program-vtables -fstrict-aliasing` on the ThinLTO bots, on stage 3 & 4, so we can catch these issues?


That's a good idea to add -fwhole-program-vtables. I will see if I can contact some of the ThinLTO bot owners about adding this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75201/new/

https://reviews.llvm.org/D75201





More information about the llvm-commits mailing list