[PATCH] D75450: [mlir] error out on unsupported attribute kinds in LLVM global translation

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:435
         type = cst->getType();
       } else {
+        if (!(cst = getLLVMConstant(type, op.getValueOrNull(), op.getLoc())))
----------------
nit: merge the if into the else


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75450/new/

https://reviews.llvm.org/D75450