[PATCH] D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

I like the idea of this and think it looks useful, and personally I would say
please do continue to work on it after giving people a chance to reply to this
comment.

I'd expect generated tests to still get attention from a human though. Debug
info doesn't all have the same value to a (compiler) user. E.g. loop induction
variables are likely very important. Because of this we like to use dexter to
target specific pain points while ignoring less important debug info. So a test
which looks at _all_ the debug info isn't necessarily indicative of user
expectations (and therefore may not be valuable).

> The current implementation also collects the set of visible variables for
>  every stack frame of every step, every single time whether we are running in
>  test or gen mode. This is not ideal performance-wise

@TWeaver is working on a feature which requires conditional breakpoints but he is
out of office at the moment.

> We found that Dexter isn't good at detecting cases where the debug experience
>  is actually better than what the test expects

We once had a similar tool, and we also always used O0 as a baseline.

> The results of tests generated using the this tool under some compiler
>  (e.g. GCC) shouldn't be trusted if ran under a different compiler (e.g. Clang)

See second paragraph in this comment.

Pending comments from Tom and no objections I think you should go for it.

Does anyone else have any comments or concerns about this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75343/new/

https://reviews.llvm.org/D75343