[PATCH] D75337: [debuginfo-tests][dexter] Add _verify_options to TestToolBase

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 08:32:20 PST 2020


StephenTozer added a comment.

LGTM except for the inline comment.



================
Comment at: debuginfo-tests/dexter/dex/tools/TestToolBase.py:97
+    # Checks if the provided options are valid/supported by this tool
+    # if it return false, the tool fails
+    def _verify_options(self, options) -> bool:
----------------
Full stop here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75337/new/

https://reviews.llvm.org/D75337





More information about the llvm-commits mailing list