[PATCH] D75339: [debuginfo-tests][dexter] Add --builder gcc support for POSIX

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 08:29:58 PST 2020


Pierre-vh added a comment.

In D75339#1901101 <https://reviews.llvm.org/D75339#1901101>, @jmorse wrote:

> Would it not be possible to override handle_options in the tool class, put the logic from _verify_options there (raising an Error if there's a problem), and then call `super(Tool,self).handle_options()` if there's no error? This would avoid the need to add a new method / code path.
>
> Otherwise, adding a gcc builder sounds great!


This is definitely possible, but I did it that way because my other change (the gen tool RFC) also needs a similar feature (see the parent diff: D75337 <https://reviews.llvm.org/D75337>)
If you prefer, I can change both this diff and D75343 <https://reviews.llvm.org/D75343> to do what you suggested, then I can simply delete the parent revision (D75337 <https://reviews.llvm.org/D75337>).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75339/new/

https://reviews.llvm.org/D75339





More information about the llvm-commits mailing list