[PATCH] D75382: [lld] Initial commit for new Mach-O backend

[Jez Ng via Phabricator via llvm-commits]

int3 marked 14 inline comments as done.
int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:103
+    isec->file = this;
+    isec->name = StringRef(sec.sectname, strnlen(sec.sectname, 16));
+    isec->segname = StringRef(sec.segname, strnlen(sec.segname, 16));
----------------
MaskRay wrote:
> `MachO/section-names.s` should test a long section name.
okay, added a 16 char section name (the maximum allowed by the format)


================
Comment at: lld/test/MachO/duplicate-symbol.s:4
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t-dup.o
+# RUN: not lld -flavor darwinnew -o %t %t-dup.o %t.o 2>&1 | FileCheck %s
+
----------------
MaskRay wrote:
> Does `lld -flavor darwinnew -o /dev/null %t.o %t.o` work?
yup it does


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75382/new/

https://reviews.llvm.org/D75382