[PATCH] D75442: [MLIR] Add includes to PointerLikeTypeTraits where needed.

Stephan Herhut via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 03:53:55 PST 2020


herhut added a comment.

In D75442#1900577 <https://reviews.llvm.org/D75442#1900577>, @ftynse wrote:

> Should we just put it in mlir/Support/LLVM.h and rely on transitivity in most cases?


The transitivity in most cases is where it get complicated. I have a failure because this got included in the wrong way/order. I can put a forward declaration into `LLVM.h` and then include that everywhere I how have `PointerLikeTypeTraits.h`. Would that work better?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75442/new/

https://reviews.llvm.org/D75442





More information about the llvm-commits mailing list