[PATCH] D75111: [MC] Allowing the use of $-prefixed integer as asm identifiers
Lucas Prates via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 2 01:55:09 PST 2020
pratlucas marked 4 inline comments as done.
pratlucas added inline comments.
================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:2867
Lexer.Lex(); // Lexer's Lex guarantees consecutive token.
// Construct the joined identifier and consume the token.
Res =
----------------
jrtc27 wrote:
> jrtc27 wrote:
> > Ditto
> Actually I think this one is still fine?
I believe this one is still fine, as it references the identifier being parsed and not the actual token.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75111/new/
https://reviews.llvm.org/D75111
More information about the llvm-commits
mailing list