[PATCH] D75428: [MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht

Stefan Agner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 00:43:29 PST 2020


falstaff84 added a comment.

This indeed looks much nicer. I was somehow under the assumption that this was not an option since we moved away from using separate instructions for {ld,st}r{,b}t:
https://github.com/llvm/llvm-project/commit/fb3950ec6312dfa4317d8cbf83a1db4aae7428ce

That said, if using separate instructions is acceptable, I am all for it.

The fact that this approach sets the unsigned bit is actually a good thing as it aligns with the behavior of GNU binutils.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75428/new/

https://reviews.llvm.org/D75428





More information about the llvm-commits mailing list