[PATCH] D75273: [entry values] ARM: Add a describeLoadedValue override (PR45025)

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 00:02:06 PST 2020


djtodoro added inline comments.


================
Comment at: llvm/test/DebugInfo/MIR/ARM/call-site-info-vmovd.mir:71
+  !22 = !DILocation(line: 0, scope: !16)
+  !23 = !DILocation(line: 3, column: 3, scope: !16)
+  !24 = !DILocation(line: 4, column: 5, scope: !16)
----------------
vsk wrote:
> djtodoro wrote:
> > We can attach only to !23.
> I'll clean up the test a bit before committing, but we really need a tool to do this kind of reduction. Having narrow/reduced test cases is important, but doing this can cost a fairly outsized amount of engineering time relative to the benefit it delivers.
> 
> The number of debug info contributors has grown a lot the past few years, and I hope it keeps growing. For that to happen though we need for an off-the-shelf tool that can help reduce tests. I'll try to prototype something soon.
I agree. Such utility could be very useful, and I would like to participate. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75273/new/

https://reviews.llvm.org/D75273





More information about the llvm-commits mailing list