[PATCH] D75385: [TargetLowering] Avoid infinite iteration on setcc fold

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 1 13:25:24 PST 2020


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:2967
     // already a zero (otherwise, infinite loop).
     auto *YConst = dyn_cast<ConstantSDNode>(Y);
     if (YConst && YConst->isNullValue())
----------------
Is this happening with vector cases, in which case would this work instead:

ConstantSDNode *YConst = isConstOrConstSplat(Y) ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75385/new/

https://reviews.llvm.org/D75385





More information about the llvm-commits mailing list