[PATCH] D71916: High-Level Code-Review Documentation Update

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/docs/CodeReview.rst:217
+on a patch, but patches should be approved only consistent with the policy above.
+
----------------
hubert.reinterpretcast wrote:
> MaskRay wrote:
> > Delete the trailing empty line.
> I am still seeing the empty line.
Hmm, it seems we hit one of the situations where Phabricator causes confusion. The empty line that @MaskRay requested removal of (https://reviews.llvm.org/D71916?id=235378#inline-651131) is the one at the end of the file (which is still present now). I am not sure if the empty line which //did// get removed is necessary in this document format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71916/new/

https://reviews.llvm.org/D71916