[PATCH] D64827: [Xtensa 2/10] Add Xtensa ELF definitions.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 18:03:59 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-types-xtensa.test:5
+# RUN: yaml2obj %s -o %t-xtensa.o
+# RUN: llvm-readobj -r --expand-relocs %t-xtensa.o | FileCheck %s
+
----------------
andreisfr wrote:
> jhenderson wrote:
> > Your comment says both llvm-readobj and llvm-readelf, but you only test one of those. As the code is generic, that's fine, but probably best to remove the llvm-readelf reference from the comment.
> Corrected
Delete --expand-relocs and you will be able to use `CHECK-NEXT:` instead of `CHECK:`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64827/new/

https://reviews.llvm.org/D64827





More information about the llvm-commits mailing list