[PATCH] D75287: [mlir][GPU] Expose the functionality to create a gpu.GPUFuncOp from a gpu.GPULaunchOp

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 15:57:46 PST 2020


antiagainst added inline comments.


================
Comment at: mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp:145
+                                       llvm::SmallVectorImpl<Value> &operands) {
+  llvm::SetVector<Value> inputOperandSet(operands.begin(), operands.end());
+  llvm::SetVector<Value> operandSet(operands.begin(), operands.end());
----------------
We are only using the "set" part here right? Just use a set data type?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75287/new/

https://reviews.llvm.org/D75287





More information about the llvm-commits mailing list