[PATCH] D75213: RFC: More principled implementation of DISubprogram::describes()

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 11:30:58 PST 2020


aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:2401
              &I, DL, Scope, SP);
-    visitMDNode(*SP);
   };
----------------
dexonsmith wrote:
> It's not obvious to me why this call is no longer necessary.
because the `SP->describes(&F)` call on line 2398 will either
- fail, in which case we found an error and can stop
- succeed, in which case we must have visited the subprogram already when we entered the function


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75213/new/

https://reviews.llvm.org/D75213





More information about the llvm-commits mailing list