[PATCH] D75372: [Support] Improve Windows widenPath and add support for long UNC paths

Andrew Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 10:51:40 PST 2020


andrewng created this revision.
andrewng added reviewers: probinson, rnk, hans.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

Check the path length limit against the length of the UTF-16 version of
the input rather than the UTF-8 equivalent, as the UTF-16 length may be
shorter. Move widenPath from the llvm::sys::path namespace to the
llvm::sys::fs namespace as this seems more appropriate. Only use the
reduced path length limit for create directory. Canonicalize using
sys::path::remove_dots().


https://reviews.llvm.org/D75372

Files:
  llvm/include/llvm/Support/FileSystem.h
  llvm/include/llvm/Support/Path.h
  llvm/lib/Support/Windows/Path.inc
  llvm/lib/Support/Windows/Program.inc
  llvm/unittests/Support/Path.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75372.247311.patch
Type: text/x-patch
Size: 10419 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200228/f9256f5e/attachment-0001.bin>


More information about the llvm-commits mailing list