[PATCH] D75341: [BFI] Use CallbackVH to notify BFI about deletion of basic blocks

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

Just a quick comment, that IMO this is a great patch to have, even without an actual test showing the non-determinism.
We've seen issues like this with BFI between passes, and I tried to prevent using a cached BFI due to precisely the problem you describe.
I did not however handle the situation of BFI being invalidated by a pass and used by the same pass. 
I'm sorry I don't have a good suggestion for your const_cast question.

The changes lgtm, but I'd let the other reviewers chime in too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75341/new/

https://reviews.llvm.org/D75341