[PATCH] D75354: Add InjectTLIMappings pass to new pass manager

Masoud Ataei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 09:55:54 PST 2020


masoud.ataei added a comment.

@Whitney @fpetrogalli @pjeeva01:
Thank you guys for those comments. About the test, as @fpetrogalli said test for attribute generation is available llvm/test/Transforms/Util/add-TLI-mappings.ll for new pass manager. And I added the test to see if it is invoked in pipeline here in this patch. As @pjeeva01 said, I need to add a test to see if the vectorized function is called in presence of the vector library option.

@fpetrogalli:
About that bug report, yes this fixes that bug.

  $ cat veclib.c 
  void foo(float *a) {
    for (int i = 0; i != 1024; ++i)
      a[i] = __builtin_expf(a[i]);
  }
  
  $ clang -O3 -S -o - veclib.c -fveclib=Accelerate -fexperimental-new-pass-manager|grep vexpf
  	bl vexpf
  	bl vexpf
  	bl vexpf
  	bl vexpf
  	bl vexpf
  	bl vexpf
  	bl vexpf
  	bl vexpf
  	bl vexpf
  	bl vexpf
  	bl vexpf
  	bl vexpf


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75354/new/

https://reviews.llvm.org/D75354





More information about the llvm-commits mailing list