[PATCH] D75322: [lld][WebAssembly] Handle mixed strong and weak undefined symbols

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/test/wasm/weak-and-strong-undef.s:2
+# Test that when a symbol (foo) is both weakly and stronly undefined the
+# string undefined symbol alwaeys generates an error, whichever object
+# file is seen first.
----------------
string->strong


================
Comment at: lld/wasm/SymbolTable.cpp:430
+
+  // Update symbol binding, if the existing symbols is weak
+  uint32_t binding = existing->flags & WASM_SYMBOL_BINDING_MASK;
----------------
symbols->symbol


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75322/new/

https://reviews.llvm.org/D75322