[PATCH] D75354: Add InjectTLIMappings pass to new pass manager

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added a comment.

In D75354#1898245 <https://reviews.llvm.org/D75354#1898245>, @pjeeva01 wrote:

> Since the InjectTLIMappings pass impacts mappings of scalar math functions to their vector counterparts in all three of the currently supported vector libraries, I would like to suggest adding a test case for each one of them. In other words, testing in the presence of -fveclib=Accelerate, -fveclib=SVML, and -fveclib=MASSV libraries.


Isn't the follwing test already doing that via the `-passes=inject-tli-mappings` option?

  rapet01 at man-08:~/projects/upstream-clang/llvm-project (master)$ cat llvm/test/Transforms/Util/add-TLI-mappings.ll
  ; RUN: opt -vector-library=SVML       -inject-tli-mappings        -S < %s | FileCheck %s  --check-prefixes=COMMON,SVML
  ; RUN: opt -vector-library=SVML       -passes=inject-tli-mappings -S < %s | FileCheck %s  --check-prefixes=COMMON,SVML
  ; RUN: opt -vector-library=MASSV      -inject-tli-mappings        -S < %s | FileCheck %s  --check-prefixes=COMMON,MASSV
  ; RUN: opt -vector-library=MASSV      -passes=inject-tli-mappings -S < %s | FileCheck %s  --check-prefixes=COMMON,MASSV
  ; RUN: opt -vector-library=Accelerate -inject-tli-mappings        -S < %s | FileCheck %s  --check-prefixes=COMMON,ACCELERATE
  ; RUN: opt -vector-library=Accelerate -passes=inject-tli-mappings -S < %s | FileCheck %s  --check-prefixes=COMMON,ACCELERATE
  
  ...

I guess all we need to do then is to make sure that the pass is executed in the new pass manager pipelines, which is what this patch is doing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75354/new/

https://reviews.llvm.org/D75354