[llvm] 2809abb - [Transform][MemCpyOpt] Add missing DebugLoc to %tmpbitcast

[via llvm-commits]

Author: Pierre-vh
Date: 2020-02-28T15:20:51Z
New Revision: 2809abbd98980156142f228258aa86314cc1d641

URL: https://github.com/llvm/llvm-project/commit/2809abbd98980156142f228258aa86314cc1d641
DIFF: https://github.com/llvm/llvm-project/commit/2809abbd98980156142f228258aa86314cc1d641.diff

LOG: [Transform][MemCpyOpt] Add missing DebugLoc to %tmpbitcast

Fix for https://bugs.llvm.org/show_bug.cgi?id=37967

Differential Revision: https://reviews.llvm.org/D75173

Added: 
    llvm/test/Transforms/MemCpyOpt/pr37967.ll

Modified: 
    llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp b/llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp
index d9ff98d21c24..0987cd6597a4 100644
--- a/llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp
+++ b/llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp
@@ -1302,9 +1302,13 @@ bool MemCpyOptPass::processByValArgument(CallSite CS, unsigned ArgNo) {
     return false;
 
   Value *TmpCast = MDep->getSource();
-  if (MDep->getSource()->getType() != ByValArg->getType())
-    TmpCast = new BitCastInst(MDep->getSource(), ByValArg->getType(),
-                              "tmpcast", CS.getInstruction());
+  if (MDep->getSource()->getType() != ByValArg->getType()) {
+    BitCastInst *TmpBitCast = new BitCastInst(MDep->getSource(), ByValArg->getType(),
+                                              "tmpcast", CS.getInstruction());
+    // Set the tmpcast's DebugLoc to MDep's
+    TmpBitCast->setDebugLoc(MDep->getDebugLoc());
+    TmpCast = TmpBitCast;
+  }
 
   LLVM_DEBUG(dbgs() << "MemCpyOptPass: Forwarding memcpy to byval:\n"
                     << "  " << *MDep << "\n"

diff  --git a/llvm/test/Transforms/MemCpyOpt/pr37967.ll b/llvm/test/Transforms/MemCpyOpt/pr37967.ll
new file mode 100644
index 000000000000..6b6a40873273
--- /dev/null
+++ b/llvm/test/Transforms/MemCpyOpt/pr37967.ll
@@ -0,0 +1,23 @@
+; RUN: opt -debugify -memcpyopt -check-debugify -S < %s 2>&1 | FileCheck %s
+
+; CHECK: CheckModuleDebugify: PASS
+
+; CHECK-LABEL: define {{.*}} @_Z3bar3Foo
+; CHECK: [[target:%.*]] = load i8*, i8** bitcast (%struct.Foo** @a to i8**), align 8, !dbg
+; CHECK: %tmpcast = bitcast i8* [[target]] to %struct.Foo*, !dbg
+
+%struct.Foo = type { i64, i64, i64 }
+
+ at a = dso_local global %struct.Foo* null, align 8
+
+define dso_local void @_Z3bar3Foo(%struct.Foo* byval(%struct.Foo) align 8 %0) {
+entry:
+  %agg.tmp = alloca %struct.Foo, align 8
+  %1 = load i8*, i8** bitcast (%struct.Foo** @a to i8**), align 8
+  %2 = bitcast %struct.Foo* %agg.tmp to i8*
+  call void @llvm.memcpy.p0i8.p0i8.i64(i8* nonnull align 8 dereferenceable(24) %2, i8* nonnull align 8 dereferenceable(24) %1, i64 24, i1 false)
+  call void @_Z3bar3Foo(%struct.Foo* nonnull byval(%struct.Foo) align 8 %agg.tmp)
+  ret void
+}
+
+declare void @llvm.memcpy.p0i8.p0i8.i64(i8* noalias nocapture writeonly, i8* noalias nocapture readonly, i64, i1 immarg) #0