[PATCH] D75175: [CallSiteInfo] Enable the call site info only for -g + optimizations

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 07:05:22 PST 2020


djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1435
+      Opts.getDebugInfo() != codegenoptions::LocTrackingOnly)
+    Opts.EmitCallSiteInfo = true;
+
----------------
djtodoro wrote:
> vsk wrote:
> > Is this a replacement for the EnableDebugEntryValues codegenopt in clang?
> It is not a full replacement, since it applies only to the Call Site Info. It could end up acting similar to EnableDebugEntryValues, but it is conceptually different.
> 
> But it should go above where the EnableDebugEntryValues was set.
But I would keep the EnableDebugEntryValue Target option as well, if that was the question.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75175/new/

https://reviews.llvm.org/D75175





More information about the llvm-commits mailing list