[PATCH] D75116: [DWARFDebugLine] Use new DWARFDataExtractor::getInitialLength

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 02:25:28 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_dwarf64_large_table.s:1-3
+# Test that we can dump the (intact) prologue of a large table which was
+# truncated. Also, make sure we don't get confused by a DWARF64 length which
+# matches one of the reserved initial length values.
----------------
This isn't a hard policy or anything, but I often find it more readable for comments in lit tests to use '##' instead of just '#', as it helps them stand out from lit and FileCheck directives.


================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_dwarf64_large_table.s:16
+# CHECK:      0x000000000badbeef      1      0      1   0             0  is_stmt end_sequence
+
+
----------------
Nit: too many blank lines here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75116/new/

https://reviews.llvm.org/D75116





More information about the llvm-commits mailing list