[PATCH] D75328: [cmake] Fix LLVM_USE_SPLIT_DWARF

[Michael Liao via Phabricator via llvm-commits]

hliao created this revision.
hliao added reviewers: echristo, pcc.
Herald added subscribers: llvm-commits, aprantl, mgorny.
Herald added a project: LLVM.

- Add `-gsplit-dwarf` as an option instead of a definition.
- Only add that option on compilers supporting dwarf splitting, such as clang and gcc.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75328

Files:
  llvm/cmake/modules/HandleLLVMOptions.cmake


Index: llvm/cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- llvm/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -748,8 +748,12 @@
 endif()
 
 # Turn on -gsplit-dwarf if requested
-if(LLVM_USE_SPLIT_DWARF)
-  add_definitions("-gsplit-dwarf")
+if (LLVM_USE_SPLIT_DWARF)
+  # Limit to clang and gcc so far. Add compilers supporting this option.
+  if (CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR
+      CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+    add_compile_options($<$<OR:$<COMPILE_LANGUAGE:C>,$<COMPILE_LANGUAGE:CXX>>:-gsplit-dwarf>)
+  endif()
 endif()
 
 add_definitions( -D__STDC_CONSTANT_MACROS )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75328.247164.patch
Type: text/x-patch
Size: 700 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200228/3292406b/attachment.bin>