[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 14:15:26 PST 2020


craig.topper added a comment.

In D75162#1896469 <https://reviews.llvm.org/D75162#1896469>, @RKSimon wrote:

> In D75162#1896365 <https://reviews.llvm.org/D75162#1896365>, @craig.topper wrote:
>
> > Should we check that this generates constrained.fpext in strict mode?
>
>
> Sure - where is the best place(s) to test this?


For the intrinsics we've tested this way so far, they're in sse-builtins-constrained.c and similar. I think we have separate files for compares that I should merge into the others. They got commited separately as I was working on compares when someone else was working on the others so I made a separate file to avoid the merge conflict.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75162/new/

https://reviews.llvm.org/D75162





More information about the llvm-commits mailing list