[PATCH] D75273: [entry values] ARM: Add a describeLoadedValue override (PR45025)

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

It looks like the MIR test cases are fairly reduced now, I can give it a shot if there's obvious cruft left?



================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.h:108
 
+  Optional<ParamLoadedValue> describeLoadedValue(const MachineInstr &MI,
+                                                 Register Reg) const override;
----------------
aprantl wrote:
> doxygen comment?
I'm not sure what's best to add, here. It looks like the practice has been to copy the doxygen comment from the base class virtual method declaration, but then the documentation could get out of sync.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75273/new/

https://reviews.llvm.org/D75273