[PATCH] D75234: [LLD] Report errors occurred while parsing debug info as warnings.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 10:26:10 PST 2020


MaskRay added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:2671
     if (Error e = cu->tryExtractDIEsIfNeeded(false)) {
-      error(toString(sec) + ": " + toString(std::move(e)));
+      warn(toString(sec) + ": " + toString(std::move(e)));
       return {};
----------------
Downgrading an error to a warning is fine.


================
Comment at: lld/test/ELF/gdb-index-parse-fail.s:5
 
-# CHECK: error: {{.*}}:(.debug_info): invalid reference to or invalid content in .debug_str_offsets[.dwo]: insufficient space for 32 bit header prefix
+# CHECK: warning: {{.*}}:{{(\(\.debug_info\):)?}} invalid reference to or invalid content in .debug_str_offsets[.dwo]: insufficient space for 32 bit header prefix
 
----------------
Why the `?` metacharacter?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75234/new/

https://reviews.llvm.org/D75234





More information about the llvm-commits mailing list