[PATCH] D65593: [Attributor] Deduction based on path exploration

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1065
     return BeforeState == S ? ChangeStatus::UNCHANGED : ChangeStatus::CHANGED;
   }
 
----------------
jdoerfert wrote:
> Can you explain the NOTE further and why we cannot make it "right"?
> 
> ---
> 
> Do you really want to delete `UsesInChild` or do you want to use it in the `followUsesInContext` call such that `Uses` is not modifed here.
> Do you really want to delete UsesInChild or do you want to use it in the followUsesInContext call such that Uses is not modifed here.

Hmm, that was my initial assumption as well:
> Probably put there since something has to be passed to the function

but I thought I was wrong.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65593/new/

https://reviews.llvm.org/D65593