[PATCH] D75257: [mlir] NFC - Split out RunnerUtils that don't require a C++ runtime

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 09:44:55 PST 2020


nicolasvasilache marked 3 inline comments as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/include/mlir/ExecutionEngine/CRunnerUtils.h:41
+/// StridedMemRef descriptor type with static rank.
+template <typename T, int N> struct StridedMemRefType {
+  T *basePtr;
----------------
ftynse wrote:
> I'm not sure templates align with the comment above saying "entities must be kept C compatible".
True, thanks, rephrased.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75257/new/

https://reviews.llvm.org/D75257





More information about the llvm-commits mailing list