[PATCH] D75266: SROA: Don't drop atomic load/store alignments (PR45010)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 09:37:12 PST 2020


efriedma accepted this revision.
efriedma added a comment.

> Changing that seems like a riskier change (I want this for 10.x) whereas copying over the alignment from the store/load seems straight-forward to me.

It's not completely obvious at first glance that the alloca is actually sufficiently aligned.  But looking a little more carefully, it should be; we're preserving the alignment of the original alloca.  So this is fine, I guess.  LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75266/new/

https://reviews.llvm.org/D75266





More information about the llvm-commits mailing list